Patch Set 3:

Note: the current version does not implement direct reading from /dev/urandom 
as a fallback when getrandom() is missing. Instead insecure rand() used and 
error is reported to caller. The reasons are twofold: 1) it's much simpler 2) 
that matches the way RAND_bytes() is used throughout OpenBSC. I can add it in 
future revisions if necessary.

Also, there's no initialization for entropy pool: if there's insufficient 
entropy than we'll fail with error as described above. I'm not sure how can I 
initialize kernel's entropy pool programmatically (or if it's possible at all) 
- any ideas would be appreciated.

-- 
To view, visit https://gerrit.osmocom.org/1526
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0241b814ea4c4ce1458f7ad76e31d390383c2048
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Holger Freyther <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-HasComments: No

Reply via email to