Patch Set 8: (1 comment)
https://gerrit.osmocom.org/#/c/2779/8/src/osmo_gsm_tester/ofono_client.py File src/osmo_gsm_tester/ofono_client.py: Line 422: def register(self, scanned_operators): > Have you tested the DBus API? If calling netreg.Register directly without a I tested it, there's a register_default.py testing it and I run it sometimes too to test this code path. Registering without calling Register works too, but still doesn't look like the good way just to wait for implementation detail/miracle to occur and become registered. I guess Register can work too because the modem can have cached some info from last run, and it's something we probably want to avoid. Some modems may scan implicitly, who nows, so better call it here just in case, let's be safe. -- To view, visit https://gerrit.osmocom.org/2779 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d9eb47eac1044550d3885adb55105c304b0c15c Gerrit-PatchSet: 8 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-HasComments: Yes
