Patch Set 2: Code-Review-1 (4 comments)
adding stow seems to be really simple. I'm generally in favor, because this finds errors in our installation targets. Let's resolve the questions though (marking -1 for that). Generally it could be helpful to put explanations as a comment in the build script instead of / in addition to the commit log, so future readers of the code can benefit. https://gerrit.osmocom.org/#/c/2691/2//COMMIT_MSG Commit Message: Line 12: has the advantage of letting the build fail if not all location listings I find this really hard to read. "Installing dependent libraries in..."? Rather write more and shorter sentences? Line 18: building when dependencies are installed in distinct directories what so forth? AFAIK those two are all that is needed? Does it also manage CFLAGS=$include_dir somehow? https://gerrit.osmocom.org/#/c/2691/2/scripts/osmo-build-dep.sh File scripts/osmo-build-dep.sh: Line 51: mkdir -p "$inst/stow" $inst is already an empty folder intended as prefix target. Do you really need another subfolder? Line 56: STOW_DIR="$inst/stow" stow --restow $project I'm curious what this does. Could it get a single line comment? -- To view, visit https://gerrit.osmocom.org/2691 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f5012419495a656912b7b71e4f76ce102c6b63a Gerrit-PatchSet: 2 Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Owner: Alexander Huemer <alexander.hue...@xx.vu> Gerrit-Reviewer: Alexander Huemer <alexander.hue...@xx.vu> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
