Patch Set 1: (3 comments)
https://gerrit.osmocom.org/#/c/2920/1//COMMIT_MSG Commit Message: Line 12: these cases accordingly.t > "to to", ".t" Oops. https://gerrit.osmocom.org/#/c/2920/1/Transceiver52M/sigProcLib.cpp File Transceiver52M/sigProcLib.cpp: Line 644: > how about c1_burst.isReal(true)? isn't that missing now? Looking at this again, c0 should be initialized with isReal(true) and changed to isReal(false) only after GMSKRotate(). Burst c1 should be initialized with isReal(false) - the default. So the original c1 setting was incorrect (but did not affect behavior), and the patch made c0 incorrect (disabling some optimizations). Changes are not trivial. I'll make a separate patch. Line 943: shape = shapeEdgeBurst(burst); > could also Noted. -- To view, visit https://gerrit.osmocom.org/2920 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If53da1bf77b5944b6117765fa98ce12e1ccdeede Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: Tom Tsou <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Tom Tsou <[email protected]> Gerrit-HasComments: Yes
