Patch Set 4: Code-Review-1 (4 comments)
https://gerrit.osmocom.org/#/c/2831/4/src/gsm/gsm0808_utils.c File src/gsm/gsm0808_utils.c: Line 688: * speech parameter (whitespace error) Line 690: * \param[in] perm_spch value from where the speech codec is derived from "value which the speech codec is derived from" and please also explicitly say which kind of value; the comment as it is leaves the reader guessing which constants or values might match this uint8_t. Line 691: * \returns zero when successfull; negative on error */ "successful" Line 695: /*! Note: This function accepts the permitted speech configuration doxygen comment in the C block? Rather include this entire paragraph in above API doc for the function, e.g. separated by "blank" line below the param description (or between brief and params if you prefer that). Also best to stick to the imperative form, dropping things like "this function does". /*! \brief summary bla. * \param ... * * Accept the permitted speech configuration from the channel type * information and compute an ... */ -- To view, visit https://gerrit.osmocom.org/2831 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I257c972e9fdf0dfe940a8d483447085bd62e50a2 Gerrit-PatchSet: 4 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
