Patch Set 4: Code-Review-1 (4 comments)
(better to not make reviewers post the same comments again. Either change the patch or explain why you don't.) https://gerrit.osmocom.org/#/c/2830/4/include/osmocom/gsm/gsm0808_utils.h File include/osmocom/gsm/gsm0808_utils.h: Line 77: * representation we use in struct gsm0808_speech_codec */ could make sense to not commit obsolete comments that are removed in a later patch of this series ... OTOH if someone still wants to keep these we can keep all or remove all at once by rejecting / merging the other commit. https://gerrit.osmocom.org/#/c/2830/4/src/gsm/gsm0808_utils.c File src/gsm/gsm0808_utils.c: Line 652: * representation we use in struct gsm0808_speech_codec Please end the \brief with a '.' at the end of the sentence. Line 660: * (See also 3GPP TS 48.008, 3.2.2.11 and 3.2.2.103) */ this still belongs in above API doc, just like I said last time. Line 680: return GSM0808_SCT_HR6; still an open question here, see PS3 comment -- To view, visit https://gerrit.osmocom.org/2830 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib26a9c20864459b2baaa04f49b6e7902ba44b7cb Gerrit-PatchSet: 4 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
