Patch Set 4: Code-Review+1 (2 comments)
https://gerrit.osmocom.org/#/c/2818/4/include/osmocom/gsm/protocol/gsm_08_08.h File include/osmocom/gsm/protocol/gsm_08_08.h: Line 409: /* 3GPP TS 48.008, 3.2.2.103 Speech Codec Type */ I guess this should be a /*! ... */ and all of the below should be /*!< ... */ comments (to appear in the doxygen API docs) Line 420: GSM0808_SCT_CSD = 0xfd, /* CSData (see also TS 26.103) */ whitespace differs: tab above, here a single space before '=' -- To view, visit https://gerrit.osmocom.org/2818 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icaa768071d4364e671bc7e6d48b82d1f07f93f93 Gerrit-PatchSet: 4 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
