Patch Set 9: Code-Review-1 (4 comments)
Again apologies, in my last comment I didn't notice that the patches are now independent. Still there is no way to commit the lc15 without the code undup, which I would have liked to do now. I would accept both at this point, but there's still a problem here, s.b... https://gerrit.osmocom.org/#/c/2894/9/contrib/jenkins_bts_trx.sh File contrib/jenkins_bts_trx.sh: Line 25 osmo-pcu removed here Line 24: --with-osmo-pcu=$deps/osmo-pcu/include \ this needs osmo-pcu https://gerrit.osmocom.org/#/c/2894/9/contrib/jenkins_oct_and_bts_trx.sh File contrib/jenkins_oct_and_bts_trx.sh: Line 25 pcu gone Line 40: --with-osmo-pcu=$deps/osmo-pcu/include \ pcu needed -- To view, visit https://gerrit.osmocom.org/2894 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic48b1f75179b9008d65219dd5a47c1ab3b886408 Gerrit-PatchSet: 9 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: André Boddenberg <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-HasComments: Yes
