Patch Set 2: (1 comment)
https://gerrit.osmocom.org/#/c/3070/2/src/trau/osmo_ortp.c File src/trau/osmo_ortp.c: Line 449: int osmo_rtp_drop_frame(struct osmo_rtp_socket *rs, unsigned int duration) drop_frame() sounds like an imperative, i.e. the function will be dropping a frame. It's more a 'dropped_frame', i.e. we are telling the osmo_rtp code that a frame was droped? or something like skipped_frame? -- To view, visit https://gerrit.osmocom.org/3070 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6099372b6231c0a4b6ea0716f46f5daee7049e1 Gerrit-PatchSet: 2 Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
