Patch Set 1: > why bother with the extra argument? A length of 0 bytes must mean > a frame with invalid CRC. What other case for zero-length can you > think of?
>From the FIXME in the code in l1_if.c, I understand that at some point we want >to check for low quality link in a similar way as we do in sysmobts or >litecell15. As that ocpthy specific code is not there yet, I still prepare the >code to avoid potential bugs when it is implemented by already guiding where >the check and return on error should be done. In the general case, afaik we have 2 different issues here where we don't want to decode the payload: payloadSize==0 or low_quality==true, which afaiu doesn't necessarily imply payloadSize==0 too. -- To view, visit https://gerrit.osmocom.org/3078 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02bf4bca041fccf96fe2986480251f96248ce2d1 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: No
