Patch Set 1: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/3098/1/src/common/l1sap.c File src/common/l1sap.c: PS1, Line 966: % I think we should introduce a generic fn-print-helper like I introduced in Change-Id Idd07a3f4a88c38398d3e844333c0104e2de23864 (dump_gsmtims). Actually, that function should move to libosmocore (and get an osmo_ prefix) and then all code should use that function. -- To view, visit https://gerrit.osmocom.org/3098 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I049f58d51333d3590361db5c0105e6899a862af6 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
