Patch Set 1: Code-Review+1

(1 comment)

good, but can be improved:

https://gerrit.osmocom.org/#/c/3102/1/src/osmo_ss7_vty.c
File src/osmo_ss7_vty.c:

Line 170:               vty_out(vty, "Invalid point code%s", VTY_NEWLINE);
also log the invalid point code: argv[0]. Same below.


-- 
To view, visit https://gerrit.osmocom.org/3102
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6d92b1d135063dfd0a26bc23a89802cb3b1a78
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-HasComments: Yes

Reply via email to