Patch Set 1: Code-Review+1 (3 comments)
functionally perfect, cosmetic tweaks suggested: https://gerrit.osmocom.org/#/c/3104/1//COMMIT_MSG Commit Message: Line 14: himself. Add two new functions: (gender neutrality is preferred. you could drop "himself") https://gerrit.osmocom.org/#/c/3104/1/include/osmocom/sigtran/osmo_ss7.h File include/osmocom/sigtran/osmo_ss7.h: Line 442: osmo_sccp_simple_client_id(void *ctx, uint32_t ss7_id, const char *name, uint32_t pc, I know that this comes from "like simple client, just with an id", but the function name reads like it returns only an ID for an existing client, instead of creating a new client on a separate entity's ID. I'd prefer "osmo_sccp_simple_client_on_ss7_id" to be unambiguous. Line 452: osmo_sccp_simple_server_id(void *ctx, uint32_t ss7_id, uint32_t pc, same -- To view, visit https://gerrit.osmocom.org/3104 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62e608253212415bddbb4c7dcf5d3b5e79c8d28e Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
