Patch Set 5: (1 comment)
https://gerrit.osmocom.org/#/c/3008/5/contrib/jenkins_lc15.sh File contrib/jenkins_lc15.sh: PS5, Line 18: "$deps" "$base" Is it really necessary to pass $deps and $base args? Imho the 4th line takes already care that those two are exported, so build_bts() should be able to simply use them. (Assuming $deps and $base never change during build.) -- To view, visit https://gerrit.osmocom.org/3008 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d09c5f2693b5ac0a4d8f2c840971e13d1ec58cf Gerrit-PatchSet: 5 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: André Boddenberg <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: blobb <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-HasComments: Yes
