Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/3075/1/Transceiver52M/UHDDevice.cpp
File Transceiver52M/UHDDevice.cpp:

PS1, Line 1188: 32767
Is there a reason to not use SHRT_MAX instead of 32767 here?


PS1, Line 1197: 32767
Line can be removed unless there is a good reason not to use SHRT_MAX.


-- 
To view, visit https://gerrit.osmocom.org/3075
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58b8b6b71648bd9cbc105ddaaa9a7cf0a31b3d47
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Tom Tsou <[email protected]>
Gerrit-HasComments: Yes

Reply via email to