Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/3141/1/configure.ac
File configure.ac:

Line 69: AM_CONDITIONAL(HAVE_DOXYGEN, test $DOXYGEN != false && test 
"x$doxygen" = "xyes")
> could also use the and operator of 'test':
I could, I already checked. From "man test":

       NOTE: Binary -a and -o are inherently ambiguous.  Use 'test EXPR1 && 
test EXPR2' or 'test  EXPR1  ||  test  EXPR2'
       instead.


-- 
To view, visit https://gerrit.osmocom.org/3141
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba1440292116af27b267c7a1fbec1c2336784efe
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-HasComments: Yes

Reply via email to