Patch Set 3: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/3103/3/src/osmo_ss7_vty.c File src/osmo_ss7_vty.c: Line 1635: { problem: this function osmo_ss7_vty_init_addr() cannot be called independently: it depends on the L_CS7_NODE to be installed first. The other functions of the same form, _init_asp and _init_sg, each call vty_init_shared() and thus make sure that the L_CS7_NODE is indeed installed. This difference in behavior isn't clear. I guess easiest would be to simply move the address book init into vty_init_shared() and have it always available. Why would a caller require the address book to not be available? Another solution in line with a recent mail of mine on openbsc@ would be to place the address book on its own, outside of the 'cs7-instance'. In that case this _init_addr() could be fully independent. -- To view, visit https://gerrit.osmocom.org/3103 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib49ab623055e9ada7f95e0163ba7e33c5f6f99cb Gerrit-PatchSet: 3 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
