Patch Set 4: (2 comments)
> Who called it with a NULL subscr? Do you think it is approriate to > call this function with a NULL subscriber? > > If nonnull attribute wouldn't influence the optimizer I would say > let's mark the parameter as non NULL. I am not entirely sure, subscr==NULL is definetly an exception. I will ask Mr. Bolsee for some background information on this patch. https://gerrit.osmocom.org/#/c/3127/3/openbsc/src/libmsc/transaction.c File openbsc/src/libmsc/transaction.c: Line 74: if (subscr == NULL) { > Is this normal? Should we log smth or caller takes care of it? Done https://gerrit.osmocom.org/#/c/3127/4/openbsc/src/libmsc/transaction.c File openbsc/src/libmsc/transaction.c: Line 75: DEBUGP(DCC, > I think this should be INFO or probably even NOTICE level, as it is not som Done -- To view, visit https://gerrit.osmocom.org/3127 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8739b6e329ab02c0064270d02ad1d6ee245520d Gerrit-PatchSet: 4 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-HasComments: Yes
