Patch Set 6: (1 comment)
> > As Max pointed out, this is mostly the same as > > https://gerrit.osmocom.org/#/c/3099/ > > > > I guess you can use osmo_dump_gsmtime inside this function and I > > will also use yours into some patches I'm doing. > > Agree? Shall you take mine and rebase on top of it or I can > cherry-pick +modify yours on top of my branch. I have now modified my version of the function so that it uses yours. The advantage in keeping mine would be that it accepts the frame number directly instead of a gsm_time struct. I have removed all dependencies, so we could safely abandon this patch if we decide that it is not worth keeping my version. https://gerrit.osmocom.org/#/c/3048/4/src/gsm/gsm_utils.c File src/gsm/gsm_utils.c: Line 757: { > I think this is too large. Please do a more realistic calculaition. Withou Done -- To view, visit https://gerrit.osmocom.org/3048 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8015d2ded3940b01b35df7b72fc35c70c25e9926 Gerrit-PatchSet: 6 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-HasComments: Yes
