Patch Set 7: Code-Review-1 (2 comments)
https://gerrit.osmocom.org/#/c/3130/7/debian/control File debian/control: Line 284: bumpversion, should we also check for this in configure.ac? https://gerrit.osmocom.org/#/c/3130/7/debian/libosmocore-dev.install File debian/libosmocore-dev.install: Line 6: osmo-release.mk usr/include Am I understanding correctly that osmo-release.mk is installed by the debian package, but not by 'make install'? IMHO 'make install' should be our definitive installation, with the debian packaging "merely" providing a convenience adaptation thereof. The debian install should not wander off the 'make install' process on its own. It would mean that in daily development I have to build debian packages to be able to use installed files; and what about non-debian systems. -- To view, visit https://gerrit.osmocom.org/3130 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I790ceb958195b9f6cbabfe8c977dc30e2bd7414b Gerrit-PatchSet: 7 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: blobb <[email protected]> Gerrit-HasComments: Yes
