Patch Set 1: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/3258/1/src/gsm/lapdm.c File src/gsm/lapdm.c: Line 422: if (dp->oph.msg && dp->oph.msg->len == 0) { we introduce three identical copies of the related code. A function should be introudced for this, and that function be called three times from related places. -- To view, visit https://gerrit.osmocom.org/3258 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb116214e8b1798d65a8b0917150496a3c14f344 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Minh-Quang Nguyen <[email protected]> Gerrit-HasComments: Yes
