Patch Set 2: Code-Review+1 (2 comments)
https://gerrit.osmocom.org/#/c/3330/2/src/sccp_user.c File src/sccp_user.c: Line 250: memset(dest_addr, 0, sizeof(*dest_addr)); (btw when https://gerrit.osmocom.org/3341 is merged this isn't strictly needed. Btw btw, hfreyther, and now me too, tend to prefer clearing by assignment: *dest_addr = (struct osmo_sccp_addr){}; but neither of these are important, just noting.) Line 251: osmo_sccp_make_addr_pc_ssn(dest_addr, ss7->cfg.primary_pc, ssn); build failure: it appears you need to #include <osmocom/sigtran/sccp_helpers.h> -- To view, visit https://gerrit.osmocom.org/3330 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I371dc9132871aad3d8321ea13cf9fd69d76eff8f Gerrit-PatchSet: 2 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
