Patch Set 2: > in general, what is your strategy for forward/backward > compatibility here? you're changing the API and ABI while keeping > the symbol name identical, breaking existing applications
Should we just bump the lib version? Otherwise we'll have to maintain two similar structures and similar, but different set of functions to operate them, which looks like an overkill here given there is only one user of this code - *#100# in osmo-nitb. As a general comment, these patches are supposed to pave the way to more patches to osmo-nitb to allow communicating un-parsed SS/USSD to an external application. Thus splitting structures and functions in a way when we can avoid parsing the whole SS/USSD request every time. -- To view, visit https://gerrit.osmocom.org/3374 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f8972b86cd4dcb54b643a24b5794a87c8758073 Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Alexander Chemeris <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Ivan Kluchnikov <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No
