Patch Set 1:

I am a bit confused here. In osmo_sccp_simple_client_on_ss7_id() we assign
asp->cfg.local.host and asp->cfg.remote.host. I could not find any possibility
to set asp->cfg.local.host, but there is asp->cfg.local.host to set
asp->cfg.remote.host. Thats why I thought that there is something missing here,
if not we can safely abandon this patch.

(Note: Also this patch still lacks writing the parameter)

-- 
To view, visit https://gerrit.osmocom.org/3271
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I115b87b08bdc4b07772b7afb9c25bc713e79945a
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pma...@sysmocom.de>
Gerrit-HasComments: No

Reply via email to