Patch Set 5: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/3350/5/tests/msc_vlr/msc_vlr_tests.c
File tests/msc_vlr/msc_vlr_tests.c:

Line 168:       log("MSC <--%s-- MS: %s",
unrelated to the current patch: In general, we have shown the MS always on the 
left (like in almost all 3GPP diagrams, ladder diagrams, ...) and the core 
network on the right. Maybe for a follow-up patch?


-- 
To view, visit https://gerrit.osmocom.org/3350
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida205d217e304337d816b14fd15e2ee435e7397d
Gerrit-PatchSet: 5
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes

Reply via email to