Patch Set 1:

(1 comment)
File openbsc/src/libmsc/smpp_openbsc.c:

Line 607: #define SMPP34_DELIVERY_RECEIPT_REQ   0x1
> (we tend to use enums instead)
OK, I didn't know about this policy.

I have a few more cleanup patches here after this, I can include such change in 
the next batch if this is not a major showstopper? This would block the entire 

Let me know, thanks for reviewing!

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I59af60fa89cd10ae973c5e122789e3e03e3728ee
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Pablo Neira Ayuso <>
Gerrit-Reviewer: Harald Welte <>
Gerrit-Reviewer: Holger Freyther <>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Keith Whyte <>
Gerrit-Reviewer: Neels Hofmeyr <>
Gerrit-Reviewer: Pablo Neira Ayuso <>
Gerrit-HasComments: Yes

Reply via email to