Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/3438/1/openbsc/src/libmsc/gsm_04_11.c
File openbsc/src/libmsc/gsm_04_11.c:

Line 692:               gsm340_rx_sms_submit(sms_report);
code cosmetics: I see from the old sms_route_mt_sms() that it looks correct 
(besides no switch(sms_mti) here which I hope you're sure is correct), but the 
code flow seems a bit weird now. The name "sms_route_mt_sms()" suggests that it 
has already been sent, which above log message also states. Yet we send it only 
later. I'm thinking the log should be moved below after sending concluded. Also 
the indicator whether it was routed or still needs to be sent seems a bit odd, 
could be made more obvious and/or clearly documented at sms_route_mt_sms() API 
doc?


-- 
To view, visit https://gerrit.osmocom.org/3438
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5cc7bb4ebadde0940f44d10c3df34707b0615160
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Holger Freyther <hol...@freyther.de>
Gerrit-Reviewer: Keith Whyte <ke...@rhizomatica.org>
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-HasComments: Yes

Reply via email to