Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/3436/1/openbsc/src/utils/smpp_mirror.c
File openbsc/src/utils/smpp_mirror.c:

Line 145:               LOGP(DSMPP, LOGL_NOTICE, "%s\n", deliver.short_message);
I guess this log statement existed to remind us that delivery receipts were not 
being handled, so I'd drop it or move to LOGL_DEBUG.


-- 
To view, visit https://gerrit.osmocom.org/3436
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I877e228d8e174430f700631edbf9955972da7892
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Holger Freyther <hol...@freyther.de>
Gerrit-Reviewer: Keith Whyte <ke...@rhizomatica.org>
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-HasComments: Yes

Reply via email to