Patch Set 1: Code-Review+1

(1 comment)
File openbsc/src/utils/smpp_mirror.c:

Line 98: static struct tlv_t *find_tlv(struct tlv_t *head, uint16_t tag)
this is kind of on its own... could it use libosmocore gsm/tlv.h instead? But I 
see that the sms code uses its own TLV code ... does it make sense to put this 
where the other TLV functions are?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b0abaa7e06ffe1bd2242c70813d8b70e9fa954f
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Pablo Neira Ayuso <>
Gerrit-Reviewer: Harald Welte <>
Gerrit-Reviewer: Holger Freyther <>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Keith Whyte <>
Gerrit-Reviewer: Neels Hofmeyr <>
Gerrit-HasComments: Yes

Reply via email to