Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/3433/1/openbsc/src/utils/smpp_mirror.c
File openbsc/src/utils/smpp_mirror.c:

Line 98: static struct tlv_t *find_tlv(struct tlv_t *head, uint16_t tag)
this is kind of on its own... could it use libosmocore gsm/tlv.h instead? But I 
see that the sms code uses its own TLV code ... does it make sense to put this 
where the other TLV functions are?


-- 
To view, visit https://gerrit.osmocom.org/3433
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b0abaa7e06ffe1bd2242c70813d8b70e9fa954f
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Holger Freyther <hol...@freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Keith Whyte <ke...@rhizomatica.org>
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-HasComments: Yes

Reply via email to