Patch Set 3:

It is likely we will at some point have secondary point codes. Hence, I would 
prefer to either have a sub-structure that encapsulates the uint32_t and the 
valid flag, so that type and related code/functions can be re-used (e.g. 
something like is_pc_valid() inline function that then can operate on that 
type).

An alternative would be to use the MSB as valid flag, as all known point code 
formats have a maximum of 24 bits in length.

-- 
To view, visit https://gerrit.osmocom.org/3355
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f0f0c89b7335d9da24161bfac8234be214ca00c
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

Reply via email to