Patch Set 1: Code-Review+2

> I need to call gsm340_rx_sms_submit() in the last patch of this
 > series, to add support for status-report in nitb mode.

Ok, then please state this briefly in the commit log, i.e. tha the code will be 
called in a context without msgb. This gives important context.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I797abce3f91447e8f397c7cf726db7425479fe0e
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Pablo Neira Ayuso <>
Gerrit-Reviewer: Harald Welte <>
Gerrit-Reviewer: Holger Freyther <>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Keith Whyte <>
Gerrit-Reviewer: Neels Hofmeyr <>
Gerrit-Reviewer: Pablo Neira Ayuso <>
Gerrit-HasComments: No

Reply via email to