Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit


to look at the new patch set (#2).

Fix gsm_pchan2chan_nr() to use RSL_CHAN_OSMO_PDCH

When converting from GSM_PCHAN_PDCH, we should generate
a RSL channel number IE with the osmocom extension
RSL_CHAN_OSMO_PDCH rather than claiming it is a regular
TCH/F channel.

This is important as this function is used by
osmo-bts, too - and it decides which channel number IE is
put in the GSMTAP header for both GSMTAP tracing as well
as the GSMTAP based osmo-bts-virtual.

In order to avoid any unintended effect on libbsc,
we make sure to modify rsl_ipacc_pdch_activate() to
always use GSM_PCHAN_TCH_F in related RSL message.

Change-Id: Ie34219e64a6d89da4a79f2db8ec73d1909fb8280
M openbsc/src/libbsc/abis_rsl.c
M openbsc/src/libcommon/gsm_data_shared.c
2 files changed, 5 insertions(+), 2 deletions(-)

  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/99/3399/2

diff --git a/openbsc/src/libbsc/abis_rsl.c b/openbsc/src/libbsc/abis_rsl.c
index f4fd6de..0ce2748 100644
--- a/openbsc/src/libbsc/abis_rsl.c
+++ b/openbsc/src/libbsc/abis_rsl.c
@@ -2439,7 +2439,7 @@
        dh = (struct abis_rsl_dchan_hdr *) msgb_put(msg, sizeof(*dh));
        init_dchan_hdr(dh, msg_type);
        dh->c.msg_discr = ABIS_RSL_MDISC_DED_CHAN;
-       dh->chan_nr = gsm_pchan2chan_nr(GSM_PCHAN_PDCH, ts->nr, 0);
+       dh->chan_nr = gsm_pchan2chan_nr(GSM_PCHAN_TCH_F, ts->nr, 0);
        DEBUGP(DRSL, "%s IPAC PDCH %sACT\n", gsm_ts_name(ts),
                act ? "" : "DE");
diff --git a/openbsc/src/libcommon/gsm_data_shared.c 
index 8992636..6302e05 100644
--- a/openbsc/src/libcommon/gsm_data_shared.c
+++ b/openbsc/src/libcommon/gsm_data_shared.c
@@ -643,11 +643,14 @@
        switch (pchan) {
        case GSM_PCHAN_TCH_F:
-       case GSM_PCHAN_PDCH:
        case GSM_PCHAN_TCH_F_PDCH:
                OSMO_ASSERT(lchan_nr == 0);
                cbits = 0x01;
+       case GSM_PCHAN_PDCH:
+               OSMO_ASSERT(lchan_nr == 0);
+               cbits = RSL_CHAN_OSMO_PDCH >> 3;
+               break;
        case GSM_PCHAN_TCH_H:
                OSMO_ASSERT(lchan_nr < 2);
                cbits = 0x02;

To view, visit https://gerrit.osmocom.org/3399
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie34219e64a6d89da4a79f2db8ec73d1909fb8280
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder

Reply via email to