Patch Set 1: Code-Review+1

(1 comment)
File src/smpp34.h:

Line 213:       SMPP34_REPLY_PATH               = 0x80,
I think an enum only makes sense for fields that are not a bit/flag mask.  The 
biggest benefit of using enum's is that you will get compiler warnings in case 
you forgot to handle one of the cases.  However, for bit-mask values, that 
won't work either.  Aynway, not critical.  To me it seems like the "mode" could 
be an enum, but everything else is flags masked into the same byte?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I91afd8b462b8fd3b2c4c5b54f4eeb7ec5b730b65
Gerrit-PatchSet: 1
Gerrit-Project: libsmpp34
Gerrit-Branch: master
Gerrit-Owner: Pablo Neira Ayuso <>
Gerrit-Reviewer: Harald Welte <>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes

Reply via email to