Patch Set 1:
Yes, and I see other issues in the current code, such as:
ret = osmux_snprintf_header(buf+offset, size, osmuxh);
if (ret < 0)
Which should not happen unless there's a parsing error inside
osmux_snprintf_header, and in that case it should be better to not return a
negative value IMHO.
This SNPRINTF_BUFFER_SIZE() macro looks quite difficult to follow, so I'm in
favour of removing it and cleaning the entire code. I'll create a task to do
this later, hopefully today.
--
To view, visit https://gerrit.osmocom.org/3521
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7cc422c181c0c5712ac8976a5be5f0ad44a9c0
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Holger Freyther <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-HasComments: No
