Patch Set 3: Code-Review+1 (1 comment)
https://gerrit.osmocom.org/#/c/3575/3/openbsc/src/gprs/sgsn_libgtp.c File openbsc/src/gprs/sgsn_libgtp.c: Line 148: LOGP(DGPRS, LOGL_ERROR, "Create PDP Context for %s\n", mmctx->imsi); I think if you want to do this, it would make sense to also print the NSAPI, as only the tuple of IMSI:NSAPI uniquely identifies a PDP context. Same for the deletion callback below. I've introduced recent changes in OpenGGSN by having some logging wrapper macros like LOGPPDP() or the like. Could make sense here, too -- To view, visit https://gerrit.osmocom.org/3575 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ada9f85af2098f9acc8a277b9026eed226b9ac2 Gerrit-PatchSet: 3 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-HasComments: Yes
