Patch Set 1: Code-Review-1 (7 comments)
https://gerrit.osmocom.org/#/c/3731/1//COMMIT_MSG Commit Message: Line 26: "Related: OS#2230" https://gerrit.osmocom.org/#/c/3731/1/src/osmo_gsm_tester/bts_osmotrx.py File src/osmo_gsm_tester/bts_osmotrx.py: Line 137: } (rather first get the defaults and then overlay this dict on top, otherwise the defaults take precedence over the actually chosen value.) But, all other chosen values come from self.conf and are used in the template directly. Can we do this as well here? https://gerrit.osmocom.org/#/c/3731/1/src/osmo_gsm_tester/bts_sysmo.py File src/osmo_gsm_tester/bts_sysmo.py: Line 154: } (same) https://gerrit.osmocom.org/#/c/3731/1/src/osmo_gsm_tester/resource.py File src/osmo_gsm_tester/resource.py: Line 527: raise RuntimeError('adding a list of reserved resources to itself?') I guess this is a fact and not a question :) https://gerrit.osmocom.org/#/c/3731/1/src/osmo_gsm_tester/suite.py File src/osmo_gsm_tester/suite.py: Line 474: (drop blank line) Line 484: arfcn = suite_run._try_reserve_arfcn(supported_bands) I assumed the arfcn could rather be resolved and picked like any other resource. So that the scenario requests an arfcn with a given band, and the resource resolution returns an unused arfcn that matches this band, and everything just falls into place. Is there something keeping us from doing so? It appears that this way starts a test run and only then figures out that there aren't enough arfcns. The idea is that we don't even start to run unless all resources are available. https://gerrit.osmocom.org/#/c/3731/1/suites/register/register_band_1900.py File suites/register/register_band_1900.py: Line 5: arfcn = suite.reserve_arfcn(band='GSM-1900') this shouldn't be a copy, just the same register test file, except that a *scenario* chooses a 1900 band. -- To view, visit https://gerrit.osmocom.org/3731 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fb5d95bed1fa50c3deaf62a7a6df3cb276bc3c9 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-HasComments: Yes
