Patch Set 2: (2 comments)
https://gerrit.osmocom.org/#/c/3723/2/example/resources.conf File example/resources.conf: Line 16: ciphers: ['a5 0', 'a5 1', 'a5 2', 'a5 3'] > 'a5 2' is a weak "export grade" cipher and globally deprecated. I assume ou De HW supports A5/2. If osmocom stack doesn't support it then I agree we can drop it. https://gerrit.osmocom.org/#/c/3723/2/src/osmo_gsm_tester/schema.py File src/osmo_gsm_tester/schema.py: Line 70: if val in ('a5 0', 'a5 1', 'a5 2', 'a5 3'): > spec wise they go up to 7 Ok I'll add the missing one. -- To view, visit https://gerrit.osmocom.org/3723 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0e368843a6e58bd3eeef36d2c0a7501296f0f3e Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
