Patch Set 1: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/3721/1/src/osmo_gsm_tester/resource.py File src/osmo_gsm_tester/resource.py: Line 449: return False It is potentially dangerous to change this logic and I want to be sure I understand why these patches are necessary. Could you include a full example, best in the form of a unit test showing why this change is necessary and that it doesn't break previous behavior? -- To view, visit https://gerrit.osmocom.org/3721 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27b372aa5906feac2843f24f5cdd0d9578d44b4d Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
