Patch Set 1: Code-Review+2 (1 comment)
https://gerrit.osmocom.org/#/c/3748/1/ggsn/ggsn.c File ggsn/ggsn.c: Line 225: cur += cur_len + 3; (a comment explaining the magic three would be nice, but obvious enough from above uint16_t and uint8_t) -- To view, visit https://gerrit.osmocom.org/3748 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc2e6716c33d78d3c3e000f529806228d8aa155e Gerrit-PatchSet: 1 Gerrit-Project: openggsn Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
