Patch Set 11: (2 comments)
Could you test my version? https://gerrit.osmocom.org/#/c/3735/10/src/sdp.c File src/sdp.c: Line 169: char *fmtp_str = NULL, *sdp; We would need to allocate this with memory as well or have a NULL check. Line 173: if (strcmp(leg->wanted_codec, "AMR") == 0) I would prefer strcmp(leg->wanted_codec, "AMR") == 0 -- To view, visit https://gerrit.osmocom.org/3735 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I938758ac4ec55db9223e3da6c3c277e8fa670055 Gerrit-PatchSet: 11 Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Owner: Keith Whyte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Keith Whyte <[email protected]> Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
