Patch Set 2: Code-Review+2 (2 comments)
https://gerrit.osmocom.org/#/c/3828/2//COMMIT_MSG Commit Message: Line 12: through this macro. "and log only when the state has changed" https://gerrit.osmocom.org/#/c/3828/2/include/openbsc/abis_rsl.h File include/openbsc/abis_rsl.h: Line 37: #define LCHAN_SET_ST(lch_, st_) \ (would even have been acceptable to name the macro exactly like the function was named, making the patch smaller. We did something like that for osmo_fsm_*, for example.) -- To view, visit https://gerrit.osmocom.org/3828 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21789f8021290965b61a54a2b23177ccbbfe8321 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
