Patch Set 1: Code-Review+1 (1 comment)
https://gerrit.osmocom.org/#/c/3829/1/src/common/oml.c File src/common/oml.c: Line 76: LOGP(DOML, LOGL_NOTICE, "Sending %s to BSC: ", get_value_string(abis_mm_event_cause_names, cause_value)); the function is called "tx_failure", shouldn't the all caps "FAILURE" remain in the log? anyway +2 for logging the cause name. -- To view, visit https://gerrit.osmocom.org/3829 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9413ecf57eaa6fc661f1a57ccdaa2f04c50ea43b Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
