Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/3834/1/src/osmo_gsm_tester/ofono_client.py File src/osmo_gsm_tester/ofono_client.py: Line 228: self.dbg('%r.PropertyChanged() -> %s=%s' % (I_MODEM, name, value)) > I'd prefer to drop all that is anyway constant. i.e. only log '%s=%s', and It's not constant because we also use that for the I_NETREG interface. I used this format on purpose to use the same one as we use for I_NETREG, and I like it because it feels pretty like when using mdbus -l or dbus-monitor and provides quick understanding on where the messages/info comes from. -- To view, visit https://gerrit.osmocom.org/3834 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If215c7d63ce1b86314ed25f8e76413b15676b7f5 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-HasComments: Yes
