Patch Set 2: > Anyway I would favor using the node name as in the other patch, > because it makes writing osmo-gsm-manuals vty references much > easier for humans: instead of <node id='32'> we can do <node > id='config-smpp'>
agreed and hence the +2 -- To view, visit https://gerrit.osmocom.org/3978 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib07fb9d9106e19f5be6539493e82b5d5991f8bc2 Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: No
