Patch Set 4: (5 comments)
https://gerrit.osmocom.org/#/c/4003/4//COMMIT_MSG Commit Message: Line 29: anymore. This patch removes the related code. IIUC all transcoding has been removed, but I can still find transcoding related VTY commands and config items, as well as code mentioning 'osmux'. Those should all go away, right? We can drop those in a later patch, too. https://gerrit.osmocom.org/#/c/4003/4/include/osmocom/mgcp/mgcp_msg.h File include/osmocom/mgcp/mgcp_msg.h: Line 39: int mgcp_parse_osmux_cid(const char *line); osmux ^ https://gerrit.osmocom.org/#/c/4003/4/include/osmocom/mgcp/osmux.h File include/osmocom/mgcp/osmux.h: Line 3: this whole file is osmux -- related to transcoding? https://gerrit.osmocom.org/#/c/4003/4/src/libosmo-mgcp/mgcp_osmux.c File src/libosmo-mgcp/mgcp_osmux.c: Line 126: h->in->osmux_seq = 0; (whitespace) Line 205: (whitespace) -- To view, visit https://gerrit.osmocom.org/4003 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie008599136c7ed8a0dfbb0cf803188975a499fc5 Gerrit-PatchSet: 4 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-HasComments: Yes
