Patch Set 2: The implementation looks very similar to existing bitvec_write_field() so it might make sense to combine the 2 into internal function which can set arbitrary values and implement both bitvec_write_field() and bitvec_write_field_lh() as tiny wrappers around it. Not critical for merging though - it can be added later on as a follow-up commit.
-- To view, visit https://gerrit.osmocom.org/3990 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36a76916a5986f098b6be6b5b779639c470725ef Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Minh-Quang Nguyen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-HasComments: No
