Patch Set 4: > Is it somehow possible to only ever call this after we actually invoked the > 'make release'?
Not that I know of unfortunately. Patches/ideas are welcome. > if bumpversion had any error messages we need to see to know what went wrong No, we only need to see it if it's relevant - if the 'make release' was called explicitly. > we would now silence those No, the issue with bumpversion will be caught by the check below. > we could also do something like Yes, but why? There're bunch of ways to hide unwanted output, I don't see a point in using anything more complex than redirection to /dev/null. -- To view, visit https://gerrit.osmocom.org/3973 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6ab79fe2f6b502ea223aa72e929dd3c75f34b5c Gerrit-PatchSet: 4 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: No
