Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/4008/1/openbsc/src/libbsc/bsc_vty.c
File openbsc/src/libbsc/bsc_vty.c:

Line 315:                               vty_out(vty, " since %s", 
ctime(&(bts->uptime)));
migt make sense to also add the number of secconds since when it is up, and 
expose this number of seconds via CTRl. If you chose to export the absolute 
timestamp, that would fail to work in case the date/time on the BSC host and on 
the CTRL user is not the same.


-- 
To view, visit https://gerrit.osmocom.org/4008
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e4e8504afe8ca467b68d41826f61654e24d9600
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes

Reply via email to