Patch Set 1: > +2 despite I'm somewhat worried of any possible fall-out
I couldn't find any use of the vty that would be negatively affected. Also the somewhat mysterious root nodes (VIEW_NODE, ENABLE_NODE) exhibit the same behavior and command lists as before this patch. The vty tests examine some of that behavior and all still pass unchanged... So I'm fairly confident that this is fine and rather prevents fallout from missing vty_install_default() calls. -- To view, visit https://gerrit.osmocom.org/3998 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5021c64a787b63314e0f2f1cba0b8fc7bff4f09b Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: No
