Patch Set 1: > Looks good to me but I wonder how was the performance impact > measured? Is there some command/script I can run to check > before/after the patch status?
If the difference is not obvious to you as a human being, I suggest something like "make clean; time make". Each time "bumpversion" is called from make, it takes about 0.6 seconds wall-clock time on my system. Calling it twice each time we're building in a new directory easily adds multiple seconds to each project build. Even a 'make clean' of libosmocore itself takes 2.6s with your osmo-release.mk vs. 0.33s with my approach. That's more than a factor 8 difference. -- To view, visit https://gerrit.osmocom.org/4127 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98b3b5fe3db39953cea969a9dfbb75889df2e1ea Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-HasComments: No
